39). Add topic files 123 to 126 #18700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshkramer
requested review from
a team,
BillWagner and
KathleenDollard
as code owners
mairaw
added
the
vendor-project
Contributor
|
Just curious, why do we care if there is or isn't quotes around the title? |
Contributor
Author
|
@Thraka, my reason for removing the quotes is not very substantial, but here it is. Quotes are only required around the title (or description) if there is a colon in it. So, if they are not required, I prefer they not be there, consistently. What it comes down to is simply that I like consistency in general, and in this case just because it is neater. |
This was referenced Jun 4, 2020
jameshkramer
force-pushed
the
br39-add-topic-files-123-to-126
branch
from
b8d4775 to
ebfb1e3
Compare
Member
|
@jameshkramer After a quick look, this is fine. I'll review more carefully after resolving the conflicts. |
Contributor
|
@jameshkramer can you resolve the conflicts here so we can review and merge? Thx! |
Contributor
Author
|
The conflicts are resolved |
mairaw
requested changes
Jun 23, 2020
Contributor
mairaw
left a comment
mairaw
left a comment
There was a problem hiding this comment.
Some quick suggestions to address
Co-authored-by: Maira Wenzel <[email protected]>
BillWagner
added
dotnet-visualbasic/svc
dotnet-csharp/svc
and removed
📚 Area - Visual Basic Guide
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for user story #1576037.
It adds four article files, makes corresponding deletions from the C# and VB folders, and adds redirection entries. It also provides fixes to toc.yml and some article files.
Please merge #18413, #18439, #18541, #18580, #18589, and #18673 before merging this.
cc: @BillWagner @mairaw @tfosmark @marteeleigh
Contributes to #4728